On Fri, Jun 07, 2019 at 07:13:47PM -0300, Fabio Estevam wrote:
Hi Tom and Heinrich,
On Fri, Jun 7, 2019 at 7:06 PM Tom Rini trini@konsulko.com wrote:
On Tue, Apr 02, 2019 at 07:19:06PM +0200, Heinrich Schuchardt wrote:
A new configuration variable CONFIG_SPL_SIZE_LIMIT is introduced to define the board specific maximum size for the SPL file.
Use Makefile function size_check() to implement the test.
Depending on the size of CONFIG_SPL_SIZE_LIMIT an error like the following is thrown:
spl/u-boot-spl.bin exceeds file size limit: limit: 30720 bytes actual: 33426 bytes excess: 2706 bytes make: *** [Makefile:1663: spl/u-boot-spl.bin] Error 1
Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de
Applied to u-boot/master, thanks!
Just tested this on mx6sabresd_defconfig, where the SPL size limit is 68 * 1024, so I passed:
CONFIG_SPL_SIZE_LIMIT=69632
but SPL builds without error and the generated size is 76800.
Any ideas why CONFIG_SPL_SIZE_LIMIT did not catch the SPL size overflow for mx6sabresd_defconfig?
So, I hit this too. SPL_SIZE_LIMIT is hex, not int. Or rather, Simon's patch changes it from int to hex, which, yeah, that's wrong. Thanks for the report, patch coming up!