Re: [U-Boot] [PATCH v3 1/4] Add run_command_list() to run a list of commands

Dear Simon Glass,

In message 1333179058-19598-1-git-send-email-sjg@chromium.org you wrote:

This new function runs a list of commands separated by semicolon or newline. We move this out of cmd_source so that it can be used by other code. The PXE code also uses the new function.

Suggested-by: Michael Walle michael@walle.cc Signed-off-by: Simon Glass sjg@chromium.org

---

Changes in v3:

• Added a few more comments on the need for malloc()
• Change PXE's printf() to a debug()
• Fix bug in built-in run_command()
• Fix commit message to mention ; and \n
• Move run_command_list() comment to header file

common/cmd_pxe.c | 20 ++---------- common/cmd_source.c | 49 +---------------------------- common/main.c | 85 +++++++++++++++++++++++++++++++++++++++++++++++++++ include/common.h | 13 ++++++++ 4 files changed, 102 insertions(+), 65 deletions(-)

Applied, thanks.

Best regards,

Wolfgang Denk