On 03/09/2012 02:29 PM, Simon Glass wrote:
On Fri, Mar 9, 2012 at 1:23 PM, Tom Warren TWarren@nvidia.com wrote:
sjg@google.com wrote at Friday, March 09, 2012 2:09 PM:
...
- I have held off responding to Stephen's patch on the ML to see what other
say. My view is that it is controversial since it changes the so-far accepted meaning of u-boot.bin and the behaviour of the U-Boot Makefile. Plus it is not really necessary as a means of informing the user since we put the pre-console putc() for exactly this problem. So I would rather leave Stephen's patch out at until people have time to decide that I am wrong about it. We already have CONFIG_OF_EMBED to build the fdt into u-boot.bin. Grant Likely had big reservations about this feature - let's not bring it in by stealth.
I don't quite see how this is bringing the feature in by stealth; the exact same set of files (one with and without appended DTB already in place) is still available, just under filenames that are likely to cause less surprise to the user.
...
Stephen, what you do you about leaving out your Makefile patch for now? It is (I think) the only controversial part of this, and is not needed to make all this work...
Yes, I'm happy with that. The issue I had was the surprising result of U-Boot hanging without giving any clues why, and that's addressed by the messages that are now printed with your latest patches.
While I still like the patch to rename the files in the top-level Makefile, I do agree that including it in a pull request without more widespread discussion and agreement is not a good idea.
BTW, happy birthday Tom.