-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
On 05/05/2013 03:28 AM, Wolfgang Denk wrote:
Dear Adnan Ali,
In message 1367660512-10489-3-git-send-email-adnan9901@yahoo.com
you wrote:
... include/crc.h | 8 + include/fs.h
| 1 + lib/Makefile | 1 + lib/crc32_c.c
| 40 ++ ...
These changes should be factored out into a separate commit. In any
case, the code should be compiled in only when needed, i. e. when
btrfs support is selected. Otherwise you just bloat the code size
and build time for all systems without need.
We should be able to make lib/crc32_c.o depend on btrfs being set,
yes. But non-command stuff should be getting garbage collected out in
most cases at last (Need to poke Albert about the patch for ARM).
Hm... do we really need yet another crc32 implementation?
We talked about this before I believe and the answer is yes :(
- --
Tom
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Thunderbird -
http://www.enigmail.net/
iQIcBAEBAgAGBQJRhnI+AAoJENk4IS6UOR1WGRMP/inIOtRRDrzuKuUOtiykWTGr
XtlODIrJNvWmXz3Vzs3zle8LhuwvCtUUs0WaXOi1VBVCCOt6fsqGjcbWYtRvfwvo
PtCUfyrJE+dA+pv2UFO+vwqBJoY1ew7ehjfrl0Z9JaO5AphXyPvcxtiRHsUDRbG+
NwGgv2RiYtH8WLzxCBAV2kXsE7HXCkHbloj/kLDah/X3fXDBQ8X+OKNkSOsgs85l
xg0HStiPbYkqrM+dLsCyd5/YEj9aXmlGa7g7amPAxHOC7lmFRaxI16uDw8p0hW/n
BrNHyE8F3acf1tTKGAyJYvVPd9Z4icUjBU/XkXDLr9tVp1GGDJ5pcWe80//AFy+S
3LQcPul3+6yqdBks5zSTNMBmUYqOceRzhJSpsDp1c7x6uMNsB3kOauoQ/UEiCitz
fn+CJND11A3fEF6XsOvzLUqw7BFnd5g7bIDXmX1Rq18tY6wwMQsZMl1jPvHkEP+R
Q0SdKwsXQcuKDMgCk0pLRzuiPNd/t/PQttuRPNG/wJegFN+L+Ers4PPwc73/km5S
4aINFzTmc2NMxUgsswk/xGeKt3fE3cvrTn2v3PR2vOPqcv76v8+CKtix8hEYF6eS
m5x2KJpQho9eno8VFTp52bU+zYy67mJ2k8UfWY5Ist8YG7koHtIKQIuZmGf9XMu4
RV6SbpltW+2hCcvDGHvd
=Lj6s
-----END PGP SIGNATURE-----
