On 22/08/2012 20:30, Troy Kisky wrote:
On 8/22/2012 12:22 AM, Stefano Babic wrote:
On 21/08/2012 19:51, Troy Kisky wrote:
On 8/20/2012 11:11 PM, Stefano Babic wrote:
On 21/08/2012 01:03, Troy Kisky wrote:
Hi Troy,
So, you are saying CONFIG_ options don't belong in imx-regs.h, or you didn't notice I stuck it there, or both???
I didn't notice, but CONFIG_ options do not belong to imx-regs.h. They must be define only inside the board configuration file.
Best regards, Stefano
Would it be acceptable to put #if defined(CONFIG_MX31) || defined(CONFIG_MX35) || defined(CONFIG_MX51) \ || defined(CONFIG_MX53) || defined(CONFIG_MX6Q) #define CONFIG_IMX_WATCHDOG /* cpu_reset implemented in watchdog */ #endif
at the bottom of config_cmd_default.h or do you have a better place in mind?
I do not think this will be accepted by Wolfgang. config_cmd_default.h is a general file and should not have any reference to SOC specific details.
We have discussed recently how we can put common code across CPU boundaries. I mean, code generic for all i.MXs (as in this case) that is then replicated under cpu/arm1136, cpu/arm926ejs,...
Maybe we can start a new thread and ask Albert (I am already asking him..) what he thinks about a arch/arm/cpu/plat-imx.
Best regards, Stefano Babic