Re: [PATCH v2 23/41] bootstd: Add support for bootflows

Hi Simon,

[...]

+/* error codes used to signal running out of things */ +enum {

• BF_NO_MORE_PARTS = -ESHUTDOWN,
• BF_NO_MORE_DEVICES = -ENODEV,

+};

+static const char *const bootflow_state[BOOTFLOWST_COUNT] = {

• "base",
• "media",
• "part",
• "fs",
• "file",
• "ready",

I can understand 'ready' as a boot state. What are the rest supposed to be ?

+};

+const char *bootflow_state_get_name(enum bootflow_state_t state) +{

• if (state < 0 || state >= BOOTFLOWST_COUNT)

• return "?";
  

s/?/Unknown/ or invalid maybe?

• return bootflow_state[state];

+}

+int bootflow_first_glob(struct bootflow **bflowp) +{

• struct bootstd_priv *std;

[...]

Regards /Ilias