Hi Lukasz,
On Apr 30, 2014, at 11:35 AM, Lukasz Majewski wrote:
Hi Pantelis,
Structure definition used type block_dev_desc_t, defined in part.h, which wasn't included in mmc.h. It worked only in circumstances when common.h, or another header using part.h was incuded in implementation files.
Signed-off-by: Mateusz Zalega m.zalega@samsung.com Cc: Minkyu Kang mk7.kang@samsung.com Cc: Pantelis Antoniou panto@antoniou-consulting.com
Changes since v1:
- none
include/mmc.h | 1 + 1 file changed, 1 insertion(+)
diff --git a/include/mmc.h b/include/mmc.h index 42d0125..bc11f45 100644 --- a/include/mmc.h +++ b/include/mmc.h @@ -12,6 +12,7 @@
#include <linux/list.h> #include <linux/compiler.h> +#include <part.h>
#define SD_VERSION_SD 0x20000 #define SD_VERSION_3 (SD_VERSION_SD | 0x300)
I've agreed with Marek Vasut about those patches. I will take them to u-boot-dfu tree and send PR to Marek.
Since this is a cleanup patch (not connected to DFU/USB) I would like to take it to the u-boot-dfu to prevent it from being vanished on the ML.
OK, please go ahead.
Pantelis, could you ACK this patch? And then I will add it to u-boot-dfu.
-- Best regards,
Lukasz Majewski
Samsung R&D Institute Poland (SRPOL) | Linux Platform Group
Acked-by: Pantelis Antoniou panto@antoniou-consulting.com