Re: [U-Boot-Users] [PATCH 13/21] Remeber the RAM and NAND detected sizes for later display

In message 1210088022-25757-14-git-send-email-stelian@popies.net you wrote:

Signed-off-by: Stelian Pop stelian@popies.net

include/asm-arm/u-boot.h | 4 ++++ lib_arm/board.c | 14 ++++++++------ 2 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/include/asm-arm/u-boot.h b/include/asm-arm/u-boot.h index c120312..dbfe2cf 100644 --- a/include/asm-arm/u-boot.h +++ b/include/asm-arm/u-boot.h @@ -48,10 +48,14 @@ typedef struct bd_info { ulong start; ulong size; } bi_dram[CONFIG_NR_DRAM_BANKS];

• ulong bi_dram_size;

Why would that be needed? Isn't adding the "size" entries above sufficient?

for (i=0; i<CONFIG_NR_DRAM_BANKS; i++) {

• size += gd->bd->bi_dram[i].size;
  

• gd->bd->bi_dram_size += gd->bd->bi_dram[i].size;
  

  } puts("DRAM: ");

• print_size(size, "\n");

• print_size(gd->bd->bi_dram_size, "\n");

We really don't need an extra variable here, me thinks.

Best regards,

Wolfgang Denk