On Fri, 07 Oct 2011 00:10:48 +0200 Wolfgang Denk wd@denx.de wrote:
Dear Lukasz Majewski,
In message 1310567392-29082-2-git-send-email-l.majewski@samsung.com you wrote:
This commit provides UDC driver support for Samsung's SoC family of processors.
Signed-off-by: Lukasz Majewski l.majewski@samsung.com Signed-off-by: Marek Szyprowski m.szyprowski@samsung.com Signed-off-by: Kyungmin Park kyungmin.park@samsung.com Cc: Minkyu Kang mk7.kang@samsung.com Cc: Remy Bohmer linux@bohmer.net
Changes for v2:
- Coding cleanups and fixes
- s3c_udc* files history and origination added
- regs-otg.h rewritten to use structs instedad of #defines
drivers/usb/gadget/Makefile | 6 +- drivers/usb/gadget/regs-otg.h | 209 +++++ drivers/usb/gadget/s3c_udc_otg.c | 892 ++++++++++++++++++ drivers/usb/gadget/s3c_udc_otg_xfer_dma.c | 1419 +++++++++++++++++++++++++++++ include/usb/lin_gadget_compat.h | 66 ++ include/usb/s3c_udc.h | 160 ++++ 6 files changed, 2749 insertions(+), 3 deletions(-) create mode 100644 drivers/usb/gadget/regs-otg.h create mode 100644 drivers/usb/gadget/s3c_udc_otg.c create mode 100644 drivers/usb/gadget/s3c_udc_otg_xfer_dma.c create mode 100644 include/usb/lin_gadget_compat.h create mode 100644 include/usb/s3c_udc.h
Checkpatch says:
total: 0 errors, 16 warnings, 2758 lines checked
Please clean up and resubmit. Thanks.
Best regards,
Wolfgang Denk
Hi Wolfgang,
I've run the checkpatch from 3.1 Linux Kernel.
Output can be seen at: http://pastebin.com/KjAKUhx0
Most warnings are related to lines over 80 characters. This code is a debug code. As fair as I remember debug print code shall not be break in Linux kernel for easier debugging.
I don't know what is the policy in u-boot. I haven't seen any guideline about breaking debug code when it is larger than 80 characters (so I stick to kernel policy).
Other warnings are related to kernel API (like the min() macro usage) which is different in u-boot.