
6 Aug
2010
6 Aug
'10
12:31 a.m.
Dear John Rigby,
In message 1281046488-25187-3-git-send-email-john.rigby@linaro.org you wrote:
Add device tree support for ARM. Based on other existing implementations. ... +#ifdef CONFIG_USB_DEVICE
- {
extern void udc_disconnect(void);
udc_disconnect();
- }
+#endif
- cleanup_before_linux();
Should the udc_disconnect(); call not be moved into cleanup_before_linux() ?
+#if defined(CONFIG_PPC) || \
- defined(CONFIG_M68K) || \
- defined(CONFIG_SPARC) || \
- defined(CONFIG_ARM)
Please sort such lists.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Why is an average signature file longer than an average Perl script??