2 Dec
2011
2 Dec
'11
9:07 p.m.
On 12/02/2011 09:12 AM, Christian Riesch wrote:
[snip]
include/configs/da850evm.h | 87 +++++++++++++++++++++++++++++++++
[snip]
+#define CONFIG_SYS_DA850_DDR2_SDTIMR (0 | \
- (14 << DV_DDR_SDTMR1_RFC_SHIFT) | \
- (2 << DV_DDR_SDTMR1_RP_SHIFT) | \
- (2 << DV_DDR_SDTMR1_RCD_SHIFT) | \
- (1 << DV_DDR_SDTMR1_WR_SHIFT) | \
- (5 << DV_DDR_SDTMR1_RAS_SHIFT) | \
- (8 << DV_DDR_SDTMR1_RC_SHIFT) | \
- (1 << DV_DDR_SDTMR1_RRD_SHIFT) | \
- (0 << DV_DDR_SDTMR1_WTR_SHIFT))
'0 | ..' and '0 << ...' don't help readability over just value saying it (same with shifting 0). Also, unless the manual these come from uses decimal here, hex is preferred. Thanks!
--
Tom