In message 1209401636-9846-2-git-send-email-gerickson@nuovations.com you wrote:
board/amcc/kilauea/init.S | 53 +++++++++++-- board/amcc/makalu/init.S | 53 +++++++++++-- cpu/ppc4xx/Makefile | 1 + cpu/ppc4xx/ecc.S | 195 +++++++++++++++++++++++++++++++++++++++++++++ cpu/ppc4xx/sdram.c | 47 +---------- 5 files changed, 292 insertions(+), 57 deletions(-)
There are a couple of problems with your posting:
- there is no signed-off-by line - there is no explanation what you're actually trying to add or to fix. - there are coding style violations: C++ comments, trailing white space, ... - the code contains way too many empty lines / vertical white space. - even in pseudo code, the Coding style requirements apply; i. e. instead of + /* + * if (start >= end) { + * return; + * } + */ please write + /* + * if (start >= end) + * return; + */ etc.
Best regards,
Wolfgang Denk