Re: [PATCH V2] cpu: imx8_cpu: Avoid revision to corrupt device tree

Hi,

On Thu, 17 Oct 2024 09:21:54 +0000 Peng Fan wrote:

...

Subject: Re: [PATCH V2] cpu: imx8_cpu: Avoid revision to corrupt device tree

Hi,

On Thu, 17 Oct 2024 16:12:36 +0800 Peng Fan (OSS) wrote:

...

From: Peng Fan peng.fan@nxp.com

U-Boot device tree is padded just after U-Boot proper. After the whole stuff loaded to DRAM space, the device tree area is conflict with BSS region before U-Boot relocation.

So any write to BSS area before reloc_fdt will corrupt the device tree. Without the fix, there is issue that "binman_init failed:-2" on i.MX8MP-EVK board.

Placing the 'revision' variable into the 'data' section would achieve the same goal without any further code change: static char revision[4] __section(".data");

This was not welcomed, https://lore.kernel.org/all/20241017034507.GJ4959@bill-the-cat/

Thanks, good to know.

Lothar Waßmann