On Wed, Oct 30, 2019 at 09:07:05PM -0600, Simon Glass wrote:
Hi Tom,
On Wed, 30 Oct 2019 at 10:15, Simon Glass sjg@chromium.org wrote:
Hi Tom,
On Wed, 30 Oct 2019 at 09:58, Tom Rini trini@konsulko.com wrote:
On Wed, Oct 30, 2019 at 09:12:39AM -0600, Simon Glass wrote:
Hi Tom,
On Wed, 30 Oct 2019 at 07:15, Tom Rini trini@konsulko.com wrote:
On Tue, Oct 29, 2019 at 07:47:55PM -0600, Simon Glass wrote:
Hi Tom,
On Thu, 24 Oct 2019 at 19:04, Simon Glass sjg@chromium.org wrote: > > Convert buildman to Python 3 and make it use that, to meet the 2020 > deadline. > > Signed-off-by: Simon Glass sjg@chromium.org > --- > > Changes in v2: None > > tools/buildman/board.py | 7 +-- > tools/buildman/bsettings.py | 20 +++---- > tools/buildman/builder.py | 45 ++++++++-------- > tools/buildman/builderthread.py | 24 ++++----- > tools/buildman/buildman.py | 10 ++-- > tools/buildman/control.py | 40 +++++++------- > tools/buildman/func_test.py | 16 +++--- > tools/buildman/test.py | 22 ++++---- > tools/buildman/toolchain.py | 93 +++++++++++++++++---------------- > 9 files changed, 139 insertions(+), 138 deletions(-)
I am a bit mystified by this:
https://gitlab.denx.de/u-boot/custodians/u-boot-dm/-/jobs/25186
It runs locally and I cannot see why it is not using unicode. Are there instructions on how to get to the same Python version as gitlab? I fear a steep learning curve coming.
First, I think the problem is this series will also need the test.py python3 series as that does a few more things to get and provide a python3 environment to use. I'll try and throw something together to test that shortly.
Second, to have the same environment locally: $ sudo docker pull trini/u-boot-gitlab-ci-runner:bionic-20191010-20Oct2019
And change the tag to whatever .gitlab-ci.yml says we use. That one is what the test.py series brings us up to, and is newer than your failing job.
$ sudo docker run --rm -it -v /your/local/u-boot/clone/..:/build/u-boot \ trini/u-boot-gitlab-ci-runner:bionic-20191010-20Oct2019 /bin/bash
And don't pass --rm if you don't want the image deleted once you exit. That will put you in a bash prompt as the user we run everything as. Follow the steps in the job as described in .gitlab-ci.yml to do a build by hand.
And yes, you want to pass in one level before your clone so that in the container you have /build/u-boot/u-boot
Thank you, that is very helpful!
It seems like the default file encoding for open() is different. I'll try again and hopefully send a v2 series soon.
Ah, yeah. That reminded me of http://patchwork.ozlabs.org/patch/1183213/ which ends up with telling open to use utf-8 and then possibly some other places we need to decode() and allow for errors to replace characters as needed rather than be fatal. I think you might have a case of the latter where it's found 'ä' or similar in the log and can't just turn it to ascii without being allowed to replace.
I think I have that patch. My tree is building here:
https://gitlab.denx.de/u-boot/custodians/u-boot-dm/pipelines/1158
But perhaps I picked up an earlier version? Is it close to being applied?
Good news is that I got a passing build on gitlab. I should be able send the series out tomorrow. The last patch is RFC but everything else should be ready for review.
Great, thanks. I'm testing the test.py series to merge currently.