On Tue, May 21, 2024 at 10:21:45AM -0600, Tom Rini wrote:
On Tue, May 21, 2024 at 07:12:09PM +0300, Andy Shevchenko wrote:
On Tue, May 21, 2024 at 08:59:17PM +0530, Kumar, Udit wrote:
On 5/21/2024 7:59 PM, Andy Shevchenko wrote:
On Tue, May 21, 2024 at 04:26:44PM +0530, Udit Kumar wrote:
...
Are you Cc'ing random people with this? Please don't do it.
I used names names popped up while running get_maintainer.pl script of u-boot
your email id was there for patch-3 of this series
Nice, the tool is broken. Please, work with the respective people to fix a tool or to tune it to avoid such mistakes in the future.
(Hint: I would first disable Git fallback completely)
So you were cc'd thanks to: commit 5e541a05f70296dbad07fc1f4e8678ad207bb476 Author: Simon Glass sjg@chromium.org Date: Sun Jul 30 21:01:45 2023 -0600
env: Use include/env for text-environment includes The 'environment' word is too long. We mostly use 'env' in U-Boot, so use that as the name of the include directory too. Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> # Intel Edison
Yeah, and it even explicitly stated what I reviewed from that code...
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>And, I'm sorry because there are other contributors who get upset when git fallback doesn't find them (because it also ages out after a year). In this case there's not even a "tweak the threshold" option since there's only a single commit to the file so you're in 100% of them.
Just an example of false positive by get_maintainer.pl :-( And a confirmation of what I said — tool is broken.