Re: [U-Boot] [PATCH v2] mmc: add mmc partconf read capability

Am 14.04.2016 um 18:56 schrieb Angelo Dureghello:

On 14/04/2016 01:16, Marek Vasut wrote:

...

On 04/14/2016 01:11 AM, Angelo Dureghello wrote:

...

diff --git a/include/mmc.h b/include/mmc.h index cdb56e7..4b34b31 100644 --- a/include/mmc.h +++ b/include/mmc.h @@ -222,6 +222,10 @@ #define EXT_CSD_BOOT_PART_NUM(x) (x << 3) #define EXT_CSD_PARTITION_ACCESS(x) (x << 0)

+#define EXT_CSD_EXTRACT_BOOT_ACK(x) ((x >> 6) & 1)

Should be (((x) >> 6) & 1) , notice the parenthesis around x.

Ok

FTR I had reviewed your use cases and they looked okay, but Marek is right that parenthesis are safer in such expressions.

Cheers, Andreas