On Tue, 11 Dec 2018 at 04:24, Boris Brezillon boris.brezillon@bootlin.com wrote:
Hi Simon,
On Mon, 10 Dec 2018 18:04:20 -0700 Simon Glass sjg@chromium.org wrote:
Hi Boris,
On Mon, 3 Dec 2018 at 14:54, Boris Brezillon boris.brezillon@bootlin.com wrote:
When auto-completing command arguments, the last argument is not necessarily the one we need to auto-complete. When the last character is a space, a tab or '\0' what we want instead is list all possible values, or if there's only one possible value, place this value on the command line instead of trying to suffix the last valid argument with missing chars.
Signed-off-by: Boris Brezillon boris.brezillon@bootlin.com Reviewed-by: Tom Rini trini@konsulko.com
Changes in v4: -None
Changes in v3:
- Add Tom's R-b
Changes in v2:
- None
common/command.c | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-)
I wonder if you might be able to add a test for this into test/py/tests ?
This is what I made, but I'm really bad at writing python scripts, so don't hesitate to propose propose something else (especially for the autocomp_command() method).
That looks about right to me.
Can you send a separate patch, and cc Stephen Warren?
Regards, Simon