Re: [U-Boot] [PATCHv6 2/6] ARMv8: add the secure monitor firmware framework

On 06/21/2016 08:42 PM, Zhiqiang Hou wrote:

<snip>

+#ifdef CONFIG_ARMV8_PSCI +/*

• • The PSCI_VERSION function is added from PSCI v0.2. When the PSCI
• • v0.1 received this function, the NOT_SUPPORTED (0xffff_ffff) error
• • number will be returned according to SMC Calling Conventions. But
• • when getting the NOT_SUPPORTED error number, we cannot ensure if
• • the PSCI version is v0.1 or other error occurred. So, PSCI v0.1
• • won't be supported by this framework.
• • And if the secure firmware isn't running, return NOT_SUPPORTED.
• • The return value on success is PSCI version in format
• • major[31:16]:minor[15:0].
• */

+unsigned int sec_firmware_support_psci_version(void) +{

• if (gd->sec_firmware & SEC_FIRMWARE_RUNNING)

• return _sec_firmware_support_psci_version();
  

• return 0xffffffff;

+} +#endif

Does _sec_firmware_support_psci_version() always return version numbers? Any chance it returns an error code?

York