Hi All, On Mon, Jun 15, 2015 at 05:53:19PM +0200, Stefano Babic wrote:
Hi Peng,
On 15/06/2015 17:17, Fabio Estevam wrote:
Hi Peng,
On Sun, Jun 14, 2015 at 6:38 AM, Peng Fan Peng.Fan@freescale.com wrote:
Since rom code supports the following commands, add new commands support in imximage.
CHECK_BITS_SET 4 [address] [mask bit] means: while ((*address & mask) != mask);
CHECK_BITS_CLR 4 [address] [mask bit] means: while ((*address & ~mask) != 0);
CLR_BIT 4 [address] [mask bit] means: *address = *address & ~mask;
dcd_v2_t is redefined, because there may not be only one write data command, there may be many different commands like CHECK_BITS_SET, CHECK_BITS_CLR and CLR_BIT.
dcd_len is still leaved there, since changing it needs changes for dcd v1. For v2, we check whether dcd size is larger than MAX_DCD_SIZE_V2, but not dcd_len.
Signed-off-by: Peng Fan Peng.Fan@freescale.com
What about just using SPL mechanism instead?
Hi Fabio, I agree that SPL can give many benifits, but we default not support it. CHECK_BITS_SET/CLR is supported by i.MX6, but current no user use this feature. This patch is actually for i.MX7 which needs these command. Since this feature is also supported by i.MX6, I make it a single patch, but not with i.MX7 patch set. As Otavio said, we should make it complete, since not everyone use SPL.
Thanks, Fabio. I can only join to your proposal.
Hi Stefano, I hope you can review this patch. I agree Otavio's idea to make feature complete, and future i.MX7 needs this feature.
Best regards, Stefano Babic
--
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de =====================================================================
Regards, Peng. --