Re: [U-Boot] [PATCH 2/3] mxs: generalize code for print_cpuinfo()

On Sun, Jun 17, 2012 at 12:49 PM, Stefano Babic sbabic@denx.de wrote:

I like that there will be support for i.MX23, too. But I dislike that everything takes the name "MX28". As you suggest in your subject, maybe it is time to rename directories, and use "mxs" (as in kernel) instead of mx28.

I have it in my wip branch; I'd like to hold it until I have mx23 working so I have freedom to rework the patches.

I can split it on mx28 part and leave mx23 on my branch; this does looks nicer for me.

...

+static u8 get_cpu_rev(void) +{

• struct mx28_digctl_regs *digctl_regs =
• (struct mx28_digctl_regs *)MXS_DIGCTL_BASE;
• return readl(&digctl_regs->hw_digctl_chipid) & 0x0000F;

+}

Everywhere (i.MX, omap, ...) get_cpu_rev returns u32. The function is currently exported, too.

I change it then.

Will fix it.