Re: [U-Boot] [PATCH] driver/mtd/spi: Default page size Spansion flash "S25FS512S" is 256b

On Mon, May 7, 2018 at 4:01 PM, Ashish Kumar Ashish.Kumar@nxp.com wrote:

Signed-off-by: Ashish Kumar Ashish.Kumar@nxp.com

drivers/mtd/spi/spi_flash.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/mtd/spi/spi_flash.c b/drivers/mtd/spi/spi_flash.c index 3d24a08..ce420cb 100644 --- a/drivers/mtd/spi/spi_flash.c +++ b/drivers/mtd/spi/spi_flash.c @@ -1046,14 +1046,15 @@ int spi_flash_scan(struct spi_flash *flash) flash->shift = (flash->dual_flash & SF_DUAL_PARALLEL_FLASH) ? 1 : 0; flash->page_size = info->page_size; /*

•    * The Spansion S25FL032P and S25FL064P have 256b pages, yet use the
  

•    * 0x4d00 Extended JEDEC code. The rest of the Spansion flashes with
  

•    * the 0x4d00 Extended JEDEC code have 512b pages. All of the others
  

•    * have 256b pages.
  

•    * The Spansion S25FS512S, S25FL032P and S25FL064P have 256b pages,
  

•    * yet use the 0x4d00 Extended JEDEC code. The rest of the Spansion
  

•    * flashes with the 0x4d00 Extended JEDEC code have 512b pages.
  

•    * All of the others have 256b pages.
     */
    if (JEDEC_EXT(info) == 0x4d00) {
            if ((JEDEC_ID(info) != 0x0215) &&
  

•               (JEDEC_ID(info) != 0x0216))
  

•               (JEDEC_ID(info) != 0x0216) &&
  

•               (JEDEC_ID(info) != 0x0220))
  

0220 is JEDEC ID for S25FS512S which is 512 is it? commit message says 256b?