
20 Apr
2007
20 Apr
'07
5:49 p.m.
In message m2irbr3wou.fsf@sowhat.denx.de you wrote:
Hm. I am eager to see the changes. If you *really* cleaned *all*
Not all, just those for the NC650 build.
warnings then I am sure you also fixed the warning in extable.c and
Indeed.
while doing this noticed that the whole fixup only works because we have a maximum of one fixup entry (./drivers/tsi108_pci.c, I cannot find any user of addr_probe anywhere). Otherwise the sorting of the table is missing and thus the searching with a bisecting algorithm will not work as is.
I didn'tnotice this, I just cleaned up the compiler warning.
I am *really looking* forward to the patch fixing that :)
Don't tell me, tell the author of the code.
Roy, are you listening?
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk
Office: Kirchenstr. 5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Man did not weave the web of life; he is merely a strand in it.
Whatever he does to the web, he does to himself. - Seattle [1854]