Hello Sam,
On Thu, Aug 16, 2018 at 11:34:13PM +0300, Sam Protsenko wrote:
dtimg command allows user to work with Android DTB/DTBO image format. Such as, getting the address of desired DTB/DTBO file, printing the dump of the image in U-Boot shell, etc.
This command is needed to provide Android boot with new Android DT image format further.
Signed-off-by: Sam Protsenko semen.protsenko@linaro.org Reviewed-by: Tom Rini trini@konsulko.com
[..]
+U_BOOT_CMD(
- dtimg, CONFIG_SYS_MAXARGS, 0, do_dtimg,
- "manipulate dtb/dtbo Android image",
- "dump <addr>\n"
- " - parse specified image and print its structure info\n"
- " <addr>: image address in RAM, in hex\n"
- "dtimg start <addr> <index> <varname>\n"
- " - get address (hex) of FDT in the image, by index\n"
- " <addr>: image address in RAM, in hex\n"
- " <index>: index of desired FDT in the image\n"
- " <varname>: name of variable where to store address of FDT\n"
- "dtimg size <addr> <index> <varname>\n"
- " - get size (hex, bytes) of FDT in the image, by index\n"
- " <addr>: image address in RAM, in hex\n"
- " <index>: index of desired FDT in the image\n"
- " <varname>: name of variable where to store size of FDT"
+);
Since you are the author and the main stakeholder of "dtimg", could you kindly feedback the command usage you envision for getting the start and size of dtb/dtbo blob given a certain "id" and "rev" fields used by mkdtboimg.py [1] and visible in the output of U-Boot's "dtimg dump" [2]?
One option would be to extend the existing "dtimg {start|size}" to accept an argument like "id:<val>" and "rev:<val>".
Another possibility is to create brand new dtimg sub-command. What would be your preference? TIA.
[1] https://android.googlesource.com/platform/system/libufdt/+/master/utils/src/... [2] https://gitlab.denx.de/u-boot/u-boot/commit/e63bf1b13b3a7a