-----Original Message----- From: Marek Behún kabel@kernel.org Sent: Monday, October 25, 2021 7:01 AM To: Roman Bacik roman.bacik@broadcom.com Cc: U-Boot Mailing List u-boot@lists.denx.de; Bharat Gooty bharat.gooty@broadcom.com; Bin Meng bmeng.cn@gmail.com; Franck LENORMAND franck.lenormand@nxp.com; Heinrich Schuchardt xypron.glpk@gmx.de; Kory Maincent kory.maincent@bootlin.com; Michal Simek michal.simek@xilinx.com; Patrick Delaunay patrick.delaunay@foss.st.com; Peng Fan peng.fan@nxp.com; Priyanka Jain priyanka.jain@nxp.com; Rayagonda Kokatanur rayagonda.kokatanur@broadcom.com; Sean Anderson sean.anderson@seco.com; Simon Glass sjg@chromium.org Subject: Re: [PATCH v2 2/2] cmd: brcm: netXtreme commands
On Fri, 22 Oct 2021 16:23:33 -0700 Roman Bacik roman.bacik@broadcom.com wrote:
From: Bharat Gooty bharat.gooty@broadcom.com
Following netXtreme commands are supported:- Device probe, remove, supported speeds, get/set speeds and get/set MAC address.
NAK.
"bnxt <bnxt_eth#> get mac
U-Boot uses the ethaddr and ethNaddr environment variables for MAC addresses. You don't need a new custom command for that when there is a generic mechanism for this.
"<bnxt_eth#> probe" / "<bnxt_eth#> remove"
You also shouldn't need a command for driver probe / remove. DM should probe your driver automatically. And if you need it for debugging, please add such subcommand to the dm command.
"bnxt <bnxt_eth#> get supported_speed" "bnxt <bnxt_eth#> get link_speed"
These should be available via the mdio command when you register your PHY driver via appropriate API.
Marek
Hi Marek,
Thank you very much for your feedback. We have two Ethernet drivers. One is 10/100/1000 MB rmii driver, which is being used as you have described. The second one is this 10/100 GB bnxt driver, which is probed and managed on demand with these netXtreme commands. We will have a look and address your comments. Thanks,
Roman