Hi,
Could someone explain me why 'ppc_4xx_eth_rx()' call 'NetReceive(...length-4)' Is it FCS, padding, VLAN tag?
Thanks Salvatore
--- Mar 9/12/08, u-boot-request@lists.denx.de u-boot-request@lists.denx.de ha scritto:
Da: u-boot-request@lists.denx.de u-boot-request@lists.denx.de Oggetto: U-Boot Digest, Vol 7, Issue 67 A: u-boot@lists.denx.de Data: Martedì 9 dicembre 2008, 01:06 Send U-Boot mailing list submissions to u-boot@lists.denx.de
To subscribe or unsubscribe via the World Wide Web, visit http://lists.denx.de/mailman/listinfo/u-boot or, via email, send a message with subject or body 'help' to u-boot-request@lists.denx.de
You can reach the person managing the list at u-boot-owner@lists.denx.de
When replying, please edit your Subject line so it is more specific than "Re: Contents of U-Boot digest..."
Today's Topics:
- Re: [PATCH 1/1] Make FAT code comply to coding rules. (Wolfgang Denk)
- Re: [PATCH] OneNAND: Fix compiler warnings (Kyungmin
Park) 3. Re: [PATCH 3/4]v2: Cleanup bootvx and handle new CONFIG_SYS_VXWORKS parameters (Wolfgang Denk) 4. [PATCH] vxworks.h: Fix build problem introduced by commits 29a4c24d/e9084b23 (Wolfgang Denk) 5. [PATCH] MAKEALL: Automatically use parallel builds (Wolfgang Denk) 6. Re: [PATCH] Section name should be ".data" not "data" (Wolfgang Denk) 7. Re: Pull request - net (Wolfgang Denk) 8. Re: AT91 Pull request (Wolfgang Denk)
Message: 1 Date: Mon, 08 Dec 2008 23:40:36 +0100 From: Wolfgang Denk wd@denx.de Subject: Re: [U-Boot] [PATCH 1/1] Make FAT code comply to coding rules. To: Remy B?hmer linux@bohmer.net Cc: u-boot@lists.denx.de Message-ID: 20081208224036.34716834B020@gemini.denx.de Content-Type: text/plain; charset=ISO-8859-1
Dear =?utf-8?q?Remy=20B=C3=B6hmer?=,
In message 1228772871-19776-1-git-send-email-linux@bohmer.net you wrote:
Currently the fat code is messy related to Coding
rules.
...but your new code has new issues, too.
- if (cur_dev->block_read) {
return cur_dev->block_read (cur_dev->dev, startblock, getsize, (unsigned long *)bufptr);- }
- if (cur_dev->block_read)
return cur_dev->block_read(cur_dev->dev,startblock, nofblocks,
(unsigned long *)bufptr);Multi-line statements do require the curly braces, and two lines is multi-line.
And this...
- actsize=bytesperclust;
- endclust=curclust;
- do {
- actsize = bytesperclust;
- endclust = curclust;
- for (;;) { /* search for consecutive clusters */
while(actsize < filesize) {
while (actsize < filesize) { newclust = get_fatent(mydata, endclust);
if((newclust -1)!=endclust)goto getit;
if ((newclust - 1) != endclust) {if (get_cluster(mydata, curclust, buffer,(int)actsize) != 0) {FAT_ERROR("Error readingcluster\n");
return -1;}gotsize += (int)actsize;filesize -= actsize;buffer += actsize;curclust = get_fatent(mydata, endclust);if (CHECK_CLUST(curclust, mydata->fatsize)) {FAT_DPRINT("curclust: 0x%x\n",curclust);FAT_ERROR("Invalid FAT entry\n");return gotsize;}actsize = bytesperclust;endclust = curclust;continue;}...looks like a massive code change, not only a coding style cleanup. Please submit as two separate patches.
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de I'm a programmer: I don't buy software, I write it. -- Tom Christiansen
Message: 2 Date: Tue, 9 Dec 2008 08:17:32 +0900 From: "Kyungmin Park" kmpark@infradead.org Subject: Re: [U-Boot] [PATCH] OneNAND: Fix compiler warnings To: "Wolfgang Denk" wd@denx.de Cc: scottwood@freescale.com, u-boot@lists.denx.de, Stefan Roese sr@denx.de Message-ID: 9c9fda240812081517k6ffaa185p6aa483b9a86a653e@mail.gmail.com Content-Type: text/plain; charset=ISO-8859-1
On Tue, Dec 9, 2008 at 5:44 AM, Wolfgang Denk wd@denx.de wrote:
Hi all,
In message
1226395733-24610-1-git-send-email-sr@denx.de you wrote:
Signed-off-by: Stefan Roese sr@denx.de
This patch has to be applied on top of the patch
submitted by Kyungmin Park
on 2008-11-04: [PATCH] [OneNAND] Sync with 2.6.27
I have to admit that I completely lost track of all
the OneNAND
patches floating around and being sent and resent and
resent again.
This is especially the case since none of the boards I
am familiar
with uses OneNAND, sso I have zero experience and
little ways to test
anything.
In short: we need a OneNAND custodian, and we need him
badly.
Is any of you volunteering, or knows of a potential
candidate?
Stefan,
Even though It's some difficult to access the external server, I can access http protocol. So I can pull the git. So if you control the git then I generate and send a patch against the OneNAND tree.
Or other ideas?
Thank you, Kyungmin Park
Message: 3 Date: Tue, 09 Dec 2008 00:28:45 +0100 From: Wolfgang Denk wd@denx.de Subject: Re: [U-Boot] [PATCH 3/4]v2: Cleanup bootvx and handle new CONFIG_SYS_VXWORKS parameters To: Niklaus Giger niklaus.giger@member.fsf.org Cc: u-boot@lists.denx.de Message-ID: 20081208232845.81CFF834B020@gemini.denx.de Content-Type: text/plain; charset=ISO-8859-1
Dear Niklaus Giger,
In message 200811032215.35182.niklaus.giger@member.fsf.org you wrote:
Signed-off-by: Niklaus Giger
common/cmd_elf.c | 81
++++++++++++++++++++----------------------------------
1 files changed, 30 insertions(+), 51 deletions(-)
Argh...
This commit breaks building ofr a lot of boards:
-> MAKEALL sequoia Configuring for sequoia board... cmd_elf.c: In function 'do_bootvx': cmd_elf.c:170: error: 'srv' undeclared (first use in this function) cmd_elf.c:170: error: (Each undeclared identifier is reported only once cmd_elf.c:170: error: for each function it appears in.) make[1]: *** [cmd_elf.o] Error 1
Will send a patch soon...
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de "Today's robots are very primitive, capable of understanding only a few simple instructions such as 'go left', 'go right', and 'build car'." - John Sladek
Message: 4 Date: Tue, 9 Dec 2008 00:28:48 +0100 From: Wolfgang Denk wd@denx.de Subject: [U-Boot] [PATCH] vxworks.h: Fix build problem introduced by commits 29a4c24d/e9084b23 To: u-boot@lists.denx.de Cc: niklaus.giger@member.fsf.org Message-ID: 1228778928-20916-1-git-send-email-wd@denx.de
Signed-off-by: Wolfgang Denk wd@denx.de
include/vxworks.h | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/include/vxworks.h b/include/vxworks.h index 548e8e8..1633904 100644 --- a/include/vxworks.h +++ b/include/vxworks.h @@ -47,7 +47,7 @@ int do_bootvx(cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]); #endif
#ifndef CONFIG_SYS_VXWORKS_SERVERNAME -#define CONFIG_SYS_VXWORKS_SERVERNAME srv +#define CONFIG_SYS_VXWORKS_SERVERNAME "srv" #endif
#endif
1.5.6.5
Message: 5 Date: Tue, 9 Dec 2008 00:41:25 +0100 From: Wolfgang Denk wd@denx.de Subject: [U-Boot] [PATCH] MAKEALL: Automatically use parallel builds To: u-boot@lists.denx.de Message-ID: 1228779685-21108-1-git-send-email-wd@denx.de
Add logic to the MAKEALL script to determine the number of CPU cores on the system, and run a parallel build if there is more than one. Usually this significantrly accelerates builds.
Allow to manually adjust the number of parallel make jobs by using the "BUILD_NCPUS" environment variable.
Signed-off-by: Wolfgang Denk wd@denx.de
MAKEALL | 11 ++++++++++- 1 files changed, 10 insertions(+), 1 deletions(-)
diff --git a/MAKEALL b/MAKEALL index dbed268..a16549c 100755 --- a/MAKEALL +++ b/MAKEALL @@ -1,6 +1,15 @@ #!/bin/sh
-: ${JOBS:=} +# Determine number of CPU cores if no default was set +: ${BUILD_NCPUS:="`getconf _NPROCESSORS_ONLN`"}
+if [ "$BUILD_NCPUS" -gt 1 ] +then
- JOBS=-j`expr "$BUILD_NCPUS" + 1`
+else
- JOBS=""
+fi
if [ "${CROSS_COMPILE}" ] ; then MAKE="make CROSS_COMPILE=${CROSS_COMPILE}" -- 1.5.6.5
Message: 6 Date: Tue, 09 Dec 2008 00:51:04 +0100 From: Wolfgang Denk wd@denx.de Subject: Re: [U-Boot] [PATCH] Section name should be ".data" not "data" To: Trent Piepho tpiepho@freescale.com Cc: u-boot@lists.denx.de Message-ID: 20081208235105.1B5D0834B020@gemini.denx.de Content-Type: text/plain; charset=ISO-8859-1
Dear Trent Piepho,
In message 1226539788-20929-1-git-send-email-tpiepho@freescale.com you wrote:
Signed-off-by: Trent Piepho
drivers/i2c/fsl_i2c.c | 7 +++---- 1 files changed, 3 insertions(+), 4 deletions(-)
Ummm... cpu/mpc8260/i2c.c, cpu/ppc4xx/i2c.c, and drivers/i2c/soft_i2c.c had the very same problem.
I fixed these, too, and merged this into your commit. Hope this is OK with you.
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de "How to make a million dollars: First, get a million dollars."
- Steve Martin
Message: 7 Date: Tue, 09 Dec 2008 01:02:35 +0100 From: Wolfgang Denk wd@denx.de Subject: Re: [U-Boot] Pull request - net To: Ben Warren biggerbadderben@gmail.com Cc: U-Boot u-boot@lists.denx.de Message-ID: 20081209000235.8B6F5834B020@gemini.denx.de Content-Type: text/plain; charset=ISO-8859-1
Dear Ben Warren,
In message 4938D2CF.5080708@gmail.com you wrote:
Wolfgang,
The following changes since commit
90665e3d97948000f98846ded37c921c7ae67dd7:
Wolfgang Denk (1): Merge branch 'master' of
git://git.denx.de/u-boot-at91
are available in the git repository at:
git://git.denx.de/u-boot-net.git master
Anatolij Gustschin (1): net: tsec: Fix Marvell 88E1121R phy init
Peter Tyser (4): net: Fix download command parsing net: Define IP flag field values net: Add additional IP fragmentation check net: Fix TftpStart() ip:filename bug
common/cmd_net.c | 20 ++++++++++++-------- drivers/net/tsec.c | 3 +++ include/net.h | 6 ++++++ include/tsec.h | 4 ++++ net/net.c | 7 ++++--- net/tftp.c | 3 +-- 6 files changed, 30 insertions(+), 13 deletions(-)
Applied, thanks.
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de "There is such a fine line between genius and stupidity."
- David St. Hubbins, "Spinal Tap"
Message: 8 Date: Tue, 09 Dec 2008 01:06:27 +0100 From: Wolfgang Denk wd@denx.de Subject: Re: [U-Boot] AT91 Pull request To: Jean-Christophe PLAGNIOL-VILLARD plagnioj@jcrosoft.com Cc: U-Boot u-boot@lists.denx.de Message-ID: 20081209000627.E69FA834B020@gemini.denx.de Content-Type: text/plain; charset=ISO-8859-1
Dear Jean-Christophe PLAGNIOL-VILLARD,
In message 20081206121309.GC2977@game.jcrosoft.org you wrote:
Hi Wolfgang, Please pull The following changes since commit
90665e3d97948000f98846ded37c921c7ae67dd7:
Wolfgang Denk (1): Merge branch 'master' of
git://git.denx.de/u-boot-at91
are available in the git repository at:
git://git.denx.de/u-boot-at91.git master
Nicolas Ferre (1): at91: Choose environment variables location
within make config target
Makefile | 60
+++++++++++++++++++++++---
doc/README.at91 | 88
+++++++++++++++++++++++++++++++++++++++
include/configs/at91sam9260ek.h | 4 -- include/configs/at91sam9261ek.h | 19 +++++++-- include/configs/at91sam9263ek.h | 3 - include/configs/at91sam9rlek.h | 3 - 6 files changed, 156 insertions(+), 21 deletions(-) create mode 100644 doc/README.at91
Applied, thanks.
Best regards,
Wolfgang Denk
-- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de The management question ... is not _whether_ to build a pilot system and throw it away. You _will_ do that. The only question is whether to plan in advance to build a throwaway, or to promise to deliver the throwaway to customers. - Fred Brooks, "The Mythical Man Month"
U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
End of U-Boot Digest, Vol 7, Issue 67