Re: [U-Boot] [PATCH v3 1/3] mx28: Let imx_get_mac_from_fuse be common for mx28

Dear Fabio,

In message 4EEA340A.3080802@denx.de Stefano Babic wrote:

On 15/12/2011 17:34, Fabio Estevam wrote:

...

Let imx_get_mac_from_fuse function be a common function, so that other mx28 boards can reuse it.

Signed-off-by: Fabio Estevam fabio.estevam@freescale.com

Hi Fabio,

...

• if (mx28_wait_mask_clr(&ocotp_regs->hw_ocotp_ctrl_reg, OCOTP_CTRL_BUSY,

• 		MXS_OCOTP_MAX_TIMEOUT)) {
  

• puts("MXS FEC: Can't get MAC from OCOTP\n");
  

• return;
  

• }
• data = readl(&ocotp_regs->hw_ocotp_cust0);
• mac[0] = 0x00;
• mac[1] = 0x04;

Maybe it is worth to add a comment to explain that the magic numbers 0x00 - 0x04 are the Freescale's vendor prefix.

This is a common file, right? Then what about boards from other vendors?

I think this is not OK as is.

Best regards,

Wolfgang Denk