-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 01/14/2014 01:27 PM, Nishanth Menon wrote:
Patch adds modification to shared omap5 abb_setup() function, and proper registers definitions needed for ABB setup sequence. ABB is initialized for MPU voltage domain at OPP_NOM.
Signed-off-by: Nishanth Menon nm@ti.com ---
arch/arm/cpu/armv7/omap5/abb.c | 13 ++++++++++--- arch/arm/cpu/armv7/omap5/prcm-regs.c | 8 ++++++++ arch/arm/include/asm/arch-omap5/omap.h | 2 ++ 3 files changed, 20 insertions(+), 3 deletions(-)
diff --git a/arch/arm/cpu/armv7/omap5/abb.c b/arch/arm/cpu/armv7/omap5/abb.c index 31b6795..3bf8897 100644 --- a/arch/arm/cpu/armv7/omap5/abb.c +++ b/arch/arm/cpu/armv7/omap5/abb.c @@ -28,18 +28,25 @@ s8 abb_setup_ldovbb(u32 fuse, u32 ldovbb) { u32 vset; + u32 fuse_enable_mask = OMAP5_ABB_FUSE_ENABLE_MASK; + u32 fuse_vset_mask = OMAP5_ABB_FUSE_VSET_MASK;
My only concern, which I know the answer to I think, is shouldn't we just have no default values here, and case in the right one for omap5/dra74x and then dra72x in the future, etc, etc. But we don't know enough really to know if future SoCs will need a different statement here, so it's good enough for now.
Reviewed-by: Tom Rini trini@ti.com
- -- Tom