
26 Mar
2009
26 Mar
'09
3:25 p.m.
Dear Stefan Roese,
In message 200903261103.28452.sr@denx.de you wrote:
#define FLASH_FIXUP_ADDR_8(addr) ((void*)((ulong)(addr)^2)) #define FLASH_FIXUP_ADDR_16(addr) ((void*)((ulong)(addr)^2))
...
Yes, I think this could be accepted. The overall impact on the driver is not too big. Let's see if others have some complaints about it. If not, I'll accept you patch after you changed some minor details.
I think that should be an inline function instead of a macro.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd@denx.de
Live long and prosper.
-- Spock, "Amok Time", stardate 3372.7