On Tue, Oct 9, 2018 at 11:20 AM Simon Glass sjg@chromium.org wrote:
Hi Cedric,
On 2 October 2018 at 09:48, Cédric Le Goater clg@kaod.org wrote:
On 10/2/18 1:22 PM, Simon Glass wrote:
On 1 October 2018 at 01:53, Cédric Le Goater clg@kaod.org wrote:
There are too many changes in the following patch fixing support for the Faraday ftgmac100 controller. To ease the review, remove the whole file which is not compiled anymore today (no Kconfig option for the driver).
Signed-off-by: Cédric Le Goater clg@kaod.org
drivers/net/ftgmac100.h | 242 ----------------- include/netdev.h | 1 - drivers/net/ftgmac100.c | 582 ---------------------------------------- drivers/net/Makefile | 1 - 4 files changed, 826 deletions(-) delete mode 100644 drivers/net/ftgmac100.h delete mode 100644 drivers/net/ftgmac100.c
Reviewed-by: Simon Glass sjg@chromium.org
Assuming Joe is happy to remove this and start again? While it is easier to review, it does remove commit history which is bad.
yes.
I have to believe there is a decent amount that is the same, no? I would prefer not to break git blame unless completely necessary.
The changes are so numerous that it is really difficult to understand what the resulting driver looks like and splitting the changes would have been nightmarish. So I took the short path as the driver was not compiled anymore, but this is questionable.
How many changes are we talking about here?
I can also resend without the initial removal patch but wouldn't it invalidate the review at the same time ?
Yes but it is not hard to re-review in this case.
Regards, Simon
Thanks, -Joe