On 09/18/2017 07:33 PM, Stephen Warren wrote:
On 09/17/2017 01:32 PM, Heinrich Schuchardt wrote:
The necessary parameters for running Python tests on qemu are tediouus to find.
The patch adds examples for u-boot-test-console and u-boot-test-reset.
This README doesn't contain examples for other cases. I'm not sure whether we should add them for qemu either. Instead, does it make sense to augment my repo, which already contains a variety of examples, and is mentioned in the README?
https://github.com/swarren/uboot-test-hooks
Tom Rini already added some qemu examples to that repo, although they use much simpler command-lines than in the examples in this patch. Perhaps that's because they fire off a new qemu instance every time the virtual system is reset, whereas yours seem to create one qemu instance and then reset it multiple times. If so, your scripts are more how I imagined it would work; perhaps you could update Tom's scripts?
I very much appreciate that your repo makes the test automation on Travis CI possible. But when looking at your repo I could not find any file that helped me to get qemu running U-Boot on my system.
When I read a documentation I do not want to be handed over to a repo where I get lost and which adds another level of external reference: "The example scripts depend on various external tools, the installation location of which must be specified in the board configuration files: As-yet-unpublished scripts to control various USB relay boards."
Sure you are free to use my examples to update your repo to provide something more accessible. But this does not obsolete this patch.
Best regards
Heinrich