On Saturday 27 August 2022 08:53:08 Tom Rini wrote:
On Sat, Aug 27, 2022 at 01:48:35PM +0200, Pali Rohár wrote:
Now when loadx and loady commands could be aborted / cancelled by CTRL+C, allow to configure timeout for initial x/y-modem packet via env variable $loadxy_timeout and by default use value from new compile-time config option CONFIG_CMD_LOADXY_TIMEOUT. Value is in seconds and zero value means infinite timeout. Default value is 90s which is the measured value used before this change for loadx and loady commands.
Other load commands loadb and loads already waits infinitely. Same behavior for loadx and loady commands can be achieved by setting $loadxy_timeout or CONFIG_CMD_LOADXY_TIMEOUT to 0.
Signed-off-by: Pali Rohár pali@kernel.org
Changes in v2:
- Allow to set timeout via env instead of permanent infinite timeout
This breaks platforms like "porter" where we have SPL_YMODEM support but do not have environment support.
By "breaks" do you mean compile error? Because if env is not set then CONFIG_CMD_LOADXY_TIMEOUT is used. Just I'm not sure if env_get() function returns NULL or what when there is no environment support.