-----Original Message----- From: York Sun [mailto:york.sun@nxp.com] Sent: Thursday, April 13, 2017 9:15 PM To: Santan Kumar santan.kumar@nxp.com; u-boot@lists.denx.de Cc: Priyanka Jain priyanka.jain@nxp.com; Abhimanyu Saini abhimanyu.saini@nxp.com Subject: Re: [PATCH 2/2][v4] armv8: ls2080aqds: Add support for SD boot
On 04/12/2017 11:18 PM, Santan Kumar wrote:
<snip>
arch/arm/cpu/armv8/fsl-layerscape/cpu.c | 6 +-- .../cpu/armv8/fsl-layerscape/fsl_lsch3_serdes.c | 6 +-- board/freescale/ls2080a/ls2080a.c | 6 +-- board/freescale/ls2080aqds/eth.c | 8 +--- board/freescale/ls2080aqds/ls2080aqds.c | 4 +- configs/ls2080aqds_sdcard_defconfig | 54
++++++++++++++++++++++
include/configs/ls2080aqds.h | 9 +++- 7 files changed, 75 insertions(+), 18 deletions(-) create mode 100644 configs/ls2080aqds_sdcard_defconfig
Please update MAINTAINERS file and add commit message. Please squash your patch which enables PPA for this boot config http://patchwork.ozlabs.org/patch/741504/
York
[Santan Kumar] Ok, I will update the MAINTAINERS file and PPA patch. In commit message: This patch adds SD boot support for LS2080aqds board. The SD boot image need to be programmed into the sdcard first. Then the booting will start from sd card. Is it ok or do you want me to add any specific information?
That's useless. Why do you add SD boot now? If there is a reason we couldn't have it before, but we can have it now, please explain.
If there is any particular instruction for SD, please add to the README file.
York
Sd-boot patches has been in-review in upstream from a long time. Also RDB board does not support SD-boot. As a feature SD-boot feature can only be tested on QDS. We will update README with proper instructions.
Priyanka