Dear Prafulla Wadaskar,
In message 73173D32E9439E4ABB5151606C3E19E202E39159C0@SC-VEXCH1.marvell.com you wrote:
- sysrst_cnt = (0x1fffffff & readl(KW_REG_SYSRST_CNT));
- printf("H/w Rst hold time: %d.%d secs\n",
sysrst_cnt / SYSRST_CNT_1SEC_VAL,sysrst_cnt % SYSRST_CNT_1SEC_VAL);This should be debvug(), too ?
Does it harm if we keep this info?
Well, yes, it does. It adds output, which makes the boot process more noisy and addds to the boot time. And normally none of the end users will actually ever look at this information.
That's understood but only in case sysrstdelay is defined which is not default case :-)
I don;t see why that should make any difference?
Really? What is the advantage for the enduser to know if he pressed the button for 5.1 or 5.3 seconds?
No, I mean it is useful in case of 4.9 or 5.1 :-)
What for? He can see the difference from different behaviour.
If you really feel you want to be verbose you can lard your definitions of bootcmd, altbootcmd, failbootcmd, sysrstcmd, etc. with any number of "echo" commands you like.
But please don't make the default output more verbose than really necessary.
Please make it a debug().
Should I? even though by default it will not show up :-)
Please do. Keep in mind: No news is good news.
Best regards,
Wolfgang Denk