Re: [U-Boot] [PATCH v2 04/17] env: move extern environment[] to environment.h

Hi Mike,

On 11/25/11 23:12, Mike Frysinger wrote:

On Thursday 17 November 2011 11:07:23 Igor Grinberg wrote:

...

--- a/tools/envcrc.c +++ b/tools/envcrc.c

#if defined(ENV_IS_EMBEDDED) && !defined(CONFIG_BUILD_ENVCRC) +# include <environment.h> # define CONFIG_BUILD_ENVCRC 1 #endif ... #ifdef CONFIG_BUILD_ENVCRC extern unsigned int env_size; -extern unsigned char environment; +extern env_t environment; #endif /* CONFIG_BUILD_ENVCRC */

this breaks when CONFIG_BUILD_ENVCRC is defined. you include environment.h when it isn't defined, but then use env_t when it is defined.

Good... eh.. I mean Bad! Thanks for testing/reporting.

Can you, please, supply the error log, so I can include it in the fix commit message?

Thanks