Dear Minkyu Kang,
Dear Marek Vasut,
On 19/09/13 23:34, Marek Vasut wrote:
Dear Marek Vasut,
Dear Marek Vasut,
Dear Mateusz Zalega,
This commit unifies board-specific USB initialization implementations under one symbol (usb_board_init), declaration of which is available in usb.h.
New API allows selective initialization of USB controllers whenever needed.
Signed-off-by: Mateusz Zalega m.zalega@samsung.com Signed-off-by: Kyungmin Park kyungmin.park@samsung.com Reviewed-by: Lukasz Majewski l.majewski@samsung.com Cc: Marek Vasut marex@denx.de Cc: Lukasz Majewski l.majewski@samsung.com Change-Id: Ia78a1378f30a55dd14598c9a1a1b4b8a762e2cd8
Changes since RFC (v1):
- NVIDIA Tegra doesn't postpone its USB init anymore
- board_usb_init()'s sole argument name was shortened
- networking code comment style (/* blurb...) dropped
- squashed RFC changes so that patch won't break bisect
v2 changes:
- commit message fixup
v3 changes:
- added 'index' argument to perform selective port initialization
v4 changes:
- board_usb_init_fail() renamed to board_usb_cleanup()
- board_usb_cleanup() accepts controller index and init type
- DFU and UMS commands don't init all USB controllers anymore
- minor related fixes & refactorization
How did you test it on all the ARM boards ?
ARCH=arm CROSS_COMPILE=arm-linux-gnueabi- BUILD_DIR=/tmp/u-boot-arm-build MAKEALL_LOGDIR=/tmp/u-boot-arm-log ./MAKEALL -a arm
does this work for you ?
Looks like this was a local issue here, sorry for the noise. Once the builds finish, I will apply for -next.
I checked powerpc and "arches" "glacier" and "glacier_nand" don't build. Can you please check and fix ? You can get the ELDK 5.4 PPC toolchain from [1].
http://www.denx.de/wiki/ELDK-5/
Best regards, Marek Vasut _______________________________________________ U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot
There are 5 patches that are sent by Mateusz Zalega. Since those patches are had dependency with this patch. Could please pick up them to -usb?
http://patchwork.ozlabs.org/patch/268786/ http://patchwork.ozlabs.org/patch/268787/ http://patchwork.ozlabs.org/patch/268788/ http://patchwork.ozlabs.org/patch/268789/
They don't touch any usb core stuff, they're just samsung-specific configuration adjustments. They should go via u-boot-samsung.
Best regards, Marek Vasut