Re: [U-Boot] [PATCH] Kirkwood: print_cpuinfo fixed for valid devid revid

Dear Prafulla Wadaskar,

In message 1284648724-6871-1-git-send-email-prafulla@marvell.com you wrote:

Earlier Device Identification register was used to detect the type for SoC, considering 88F6282 support to be added, It is not possible to detect the same using current algorithm.

With this patch, device ID is being read using PCIE devid register, also valid chip revision ID will also be read and displayed

Signed-off-by: Prafulla Wadaskar prafulla@marvell.com

...

• if ((readl(KW_REG_DEVICE_ID) & 0x03) > 2) {

• debug("Error.. %s:Unsupported Kirkwood SoC\n", __FUNCTION__);
  

• return -1;
  

Please use a printf() instead of debug() here - error messages should always be printed.

• sprintf(name, "%04x", devid);
• printf("SoC: Kirkwood 88F%s_%s\n", name, rev);

Why do you need a separate sprintf() here? Why not simply:

printf("SoC: Kirkwood 88F%04x_%s\n", devid, rev);

?

Best regards,

Wolfgang Denk