-----Original Message----- From: Stefan Roese [mailto:sr@denx.de] Sent: Tuesday, May 26, 2009 1:11 PM To: Prafulla Wadaskar Cc: u-boot@lists.denx.de Subject: Re: [U-Boot] [PATCH v10] Marvell Kirkwood family SOC support
On Tuesday 26 May 2009 09:28:29 Prafulla Wadaskar wrote:
Do you also have a NAND driver for Kirkwood in your queue? I'm asking since I need NAND support for my custom board. If you don't have any I will port the one from the 1.1.4 Marvell
version to
mainline.
Hi Stefan No need, NAND support is already mainlined in u-boot, you
just need to
use it I have used it for Sheevaplug board support please see the patch http://lists.denx.de/pipermail/u-boot/2009-May/053158.html
I know that NAND support is generally available in U-Boot. But what's currently missing is the platform/board specific driver for Kirkwood. Seems that you included the Kirkwood NAND driver into your Sheevaplug support patch. Good. But this driver should be placed in drivers/mtd/nand so that other Kirkwood boards can use it as well.
Good Feedback... The name board_nand_init() is confusing here.... Why the board specific code is in drivers/mtd/nand/? Whereas I can see more references in board/* But looking other code references in this folder your feedback stands valid BTW: the arch_nand_init() or device_nand_init() is the right name here...Scott need to suggest on this since it involves rework on other drivers too.
Meanwhile for my next patch update I will move nand.c from sheevaplug to drivers/mtd/nand/kirkwood_nand.c
Regards.. Prafulla . .