Re: [U-Boot] [PATCH] mmc: seperate block number into small parts for multi-write cmd

Dear Lei Wen,

In message 1283757567-15161-1-git-send-email-leiwen@marvell.com you wrote:

As mmc host limitation, the max number of block in one go should be limited to 65535, and the max buffer size should not excceed 512k bytes.

There is a typo in the Subject ("separate"), and actually I think the Subject is a bit misleading. How about "limit block count for multi-block write commands" or so?

• data.blocks = blkcnt;

• data.blocks = blocknum;

Be careful with your variable names. Most people will read "blocknum" as "block number" (and interpret it as an index, i. e. as the logical block address on the device), while you probably mean "number of block" - the old name "blkcnt" was more appropriate.

Why is mmc_write_block() not static?

Best regards,

Wolfgang Denk