On Wed, 2005-08-03 at 04:31, Wolfgang Denk wrote:
In message 1123024299.2614.37.camel@cashmere.sps.mot.com you wrote:
I have fixed up the request style issues now.
Thanks.
I have also remerged with the current head as of a couple hours ago. Also, I've brought up an rsync server, so my git trees at http://www.jdl.com/git_repos/ will feed you http or rsync as needed.
Thanks, worked fine for me.
Good to hear!
I understand that it would cause an unacceptable anmount of work for you to re-unwind all these modifications, but please note that this is a one time exception I will make. From now on please use separate branches for boards and processors as discussed.
Thanks. Will do.
I see the following problems with your new code (I guess you missed to run the MAKEALL script ???)
I ran MAKEALL on 85xx and 83xx boards.
MPC8349ADS:
cpu.c: In function `do_reset': cpu.c:77: warning: unused variable `addr' pci.c: In function `pci_mpc83xx_init': pci.c:119: warning: implicit declaration of function `i2c_init' pci.c:122: warning: implicit declaration of function `i2c_write' ... pci.c:247: warning: passing arg 1 of `pci_register_hose' discards qualifiers from pointer target type pci.c:248: warning: passing arg 1 of `pci_hose_scan' discards qualifiers from pointer target type pci.c:54: warning: unused variable `tmp8' pci.c:55: warning: unused variable `tmp16' spd_sdram.c:84:2: warning: #warning Current spd_sdram does not fit its usage... adjust implementation or API...
Grumble. They didn't hit the LOG/ file. I'll try to update an 8349 (branch) and clean some of this up!
Thanks, jdl