Re: [U-Boot] [PATCH v4 1/8] omap-common: Common boot code OMAP3 support and cleanup

Le mardi 14 juillet 2015 à 18:11 -0400, Tom Rini a écrit :

On Thu, Jul 02, 2015 at 12:19:37AM +0200, Paul Kocialkowski wrote:

[snip]

...

@@ -152,7 +172,7 @@ void __noreturn jump_to_image_no_args(struct spl_image_info *spl_image)

debug("image entry point: 0x%X\n", spl_image->entry_point); /* Pass the saved boot_params from rom code */

• image_entry((u32 *)&gd->arch.omap_boot_params);

• image_entry((u32 *)*((u32 *)OMAP_SRAM_SCRATCH_BOOT_PARAMS));

OK, that's a bit too much casting in there.

Well, I could separate this in a few lines with clearer casting indeed !