Re: [U-Boot] [PATCH v3 09/15] env: Support multiple environments

On Tue, Feb 06, 2018 at 09:09:07AM +0100, Simon Goldschmidt wrote:

On 23.01.2018 21:16, Maxime Ripard wrote:

...

Now that we have everything in place to support multiple environment, let's make sure the current code can use it.

I get more build errors testing this feature: there's a global variable 'env_ptr' declared in flash, nand, nvram and remote env drivers (declared as extern in envrionment.h). From reading the code, it seems like these could just be changed to static, since 'env_ptr' is not used outside these drivers?

Given Joakim's comment, I guess we should keep them !static, rename them to $env_env_ptr, and remove the definition in the include/environment that doesn't seem used anywhere.

Maxime