On 9/28/23 16:54, Andre Przywara wrote:
From: Samuel Holland samuel@sholland.org
Since the D1 CCU binding is defined, we can add support for its gates/resets, following the pattern of the existing drivers.
Signed-off-by: Samuel Holland samuel@sholland.org Reviewed-by: Andre Przywara andre.przywara@arm.com Acked-by: Sean Anderson seanga2@gmail.com Signed-off-by: Andre Przywara andre.przywara@arm.com
drivers/clk/sunxi/Kconfig | 6 + drivers/clk/sunxi/Makefile | 1 + drivers/clk/sunxi/clk_d1.c | 84 ++++++++++++ drivers/clk/sunxi/clk_sunxi.c | 5 + include/dt-bindings/clock/sun20i-d1-ccu.h | 158 ++++++++++++++++++++++ include/dt-bindings/reset/sun20i-d1-ccu.h | 79 +++++++++++ 6 files changed, 333 insertions(+) create mode 100644 drivers/clk/sunxi/clk_d1.c create mode 100644 include/dt-bindings/clock/sun20i-d1-ccu.h create mode 100644 include/dt-bindings/reset/sun20i-d1-ccu.h
[...] diff --git a/drivers/clk/sunxi/clk_sunxi.c b/drivers/clk/sunxi/clk_sunxi.c index ec02a2d0370..a0011a35d91 100644 --- a/drivers/clk/sunxi/clk_sunxi.c +++ b/drivers/clk/sunxi/clk_sunxi.c @@ -118,6 +118,7 @@ extern const struct ccu_desc a64_ccu_desc; extern const struct ccu_desc a80_ccu_desc; extern const struct ccu_desc a80_mmc_clk_desc; extern const struct ccu_desc a83t_ccu_desc; +extern const struct ccu_desc d1_ccu_desc; extern const struct ccu_desc f1c100s_ccu_desc; extern const struct ccu_desc h3_ccu_desc; extern const struct ccu_desc h6_ccu_desc; @@ -214,6 +215,10 @@ static const struct udevice_id sunxi_clk_ids[] = { #ifdef CONFIG_CLK_SUNIV_F1C100S { .compatible = "allwinner,suniv-f1c100s-ccu", .data = (ulong)&f1c100s_ccu_desc }, +#endif +#ifdef CONFIG_CLK_SUN20I_D1
- { .compatible = "allwinner,sun20i-d1-ccu",
.data = (ulong)&d1_ccu_desc },
Please keep these entries sorted numerically. Otherwise, your changes look good to me.
Regards, Samuel