Dear Haiying.Wang@freescale.com,
In message 1291218463-4211-1-git-send-email-Haiying.Wang@freescale.com you wrote:
From: Haiying Wang Haiying.Wang@freescale.com
Signed-off-by: Haiying Wang Haiying.Wang@freescale.com
Splitted from TPL patch to only address 85xx changes arch/powerpc/cpu/mpc85xx/cpu_init_nand.c | 34 ++++++++++- arch/powerpc/cpu/mpc85xx/start.S | 12 ++-- arch/powerpc/cpu/mpc85xx/u-boot-tpl.lds | 99 ++++++++++++++++++++++++++++++ 3 files changed, 137 insertions(+), 8 deletions(-) create mode 100644 arch/powerpc/cpu/mpc85xx/u-boot-tpl.lds
...
- Copyright 2009 Freescale Semiconductor, Inc.
- Copyright 2010 Freescale Semiconductor, Inc.
You should not undo a previous copyright. I guess you mean:
Copyright 2009-2010 Freescale Semiconductor, Inc.
?
+DECLARE_GLOBAL_DATA_PTR;
Please move this up to top of file.
+unsigned long get_tbclk(void) +{ +#ifdef CONFIG_FSL_CORENET
- return (gd->bus_clk + 8) / 16;
+#else
- return (gd->bus_clk + 4UL)/8UL;
+#endif
This looks inconsistent. Either this should be "... +8UL) / 16UL" or "... + 4) / 8;"
-#ifndef CONFIG_NAND_SPL +#if !defined(CONFIG_NAND_SPL) && !defined(CONFIG_TPL_BOOT) GOT_ENTRY(_start) GOT_ENTRY(_start_of_vectors) GOT_ENTRY(_end_of_vectors) GOT_ENTRY(transfer_to_handler) -#endif +#endif /* !CONFIG_TPL_BOOT || !CONFIG_NAND_SPL*/
Should that be
#endif /* !CONFIG_TPL_BOOT && !CONFIG_NAND_SPL*/
instead?
And can we please make this consistent, i. e. as you do in the following:
+#endif /* !CONFIG_NAND_SPL && !CONFIG_TPL_BOOT */
Best regards,
Wolfgang Denk