Re: [U-Boot] [PATCH 11/16] efi_loader: implement DisconnectController

Hi Heinrich,

On 17 December 2017 at 08:43, Heinrich Schuchardt xypron.glpk@gmx.de wrote:

Unfortunately we need a forward declaration because both OpenProtocol and CloseProtocol have to call DisconnectController. And DisconnectController calls both OpenProtcol and CloseProtocol.

Signed-off-by: Heinrich Schuchardt xypron.glpk@gmx.de

lib/efi_loader/efi_boottime.c | 283 ++++++++++++++++++++++++++++++++++++++---- 1 file changed, 261 insertions(+), 22 deletions(-)

Reviewed-by: Simon Glass sjg@chromium.org

I think it would be good to reduce the length of some of the identifies.

e.g. numbers_of_children -> child_count or num_children

It's just too verbose for U-Boot IMO.

- Simon