Since priv->init_voltage is an unsigned integer it can never be negative. So the current code fails to detect a missing 'regulator-init-microvolt' property and instead misconfigures the PWM device. Fix this by making the relevant members of 'struct pwm_regulator_info' signed integers.
Signed-off-by: Mark Kettenis kettenis@openbsd.org ---
The current device tree for the Firefly-RK3399 does not have a 'regulator-init-microvolt' property for the 'vdd-log' regulator. Without this fix U-Boot configures a voltage that is too low which causes the Ethernet interface to drop almost all packets.
This is the same patch that I sent a couple of days ago, but was bounced since I wasn't subscribed to the mailing list at that point. Funily enough the message did make it into the mailing list archive. Resending to make sure it does reach subscribers.
drivers/power/regulator/pwm_regulator.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
Applied to u-boot-rockchip, thanks!