
Hi Tom,
On 26 July 2017 at 10:11, Tom Rini trini@konsulko.com wrote:
On Sun, Jul 23, 2017 at 09:20:06PM -0600, Simon Glass wrote:
We are now using an env_ prefix for environment functions. Rename these for consistency. Also add function comments in common.h.
Suggested-by: Wolfgang Denk wd@denx.de Signed-off-by: Simon Glass sjg@chromium.org
Changes in v2:
- Add new patch to rename setenv() and friends to env_set()
[snip]
214 files changed, 630 insertions(+), 599 deletions(-)
This gets pretty massive, and the "and friends" includes things like eth_setenv_enetaddr and fsl_setenv_chain_of_trust. Wolfgang, since it was your suggestion, how about we just rename setenv() to env_set() to match the rest and leave "and friends" alone? Thanks!
I'm fine with that. It does leave some inconsistency though. Is that the end state you want?
Regards, Simon