Wolfgang? Are you okay with this part of my patch?
On Wed, Aug 19, 2009 at 9:40 AM, Kumar Galagalak@kernel.crashing.org wrote:
On Aug 18, 2009, at 5:28 PM, Timur Tabi wrote:
The "mac id" command took a 4-character parameter as the identifier string. However, for any given board, only one kind of identifier is acceptable, so it makes no sense to ask the user to type it in. Instead, if the user enters "mac id", the identifier (and also the version, if it's NXID) will automatically be set to the correct value.
Improve the message that is displayed when EEPROM is read during boot. It now displays "EEPROM:" and then either an error message or the EEPROM identifier if successful.
If the identifier in EEPROM is valid, then always reject a bad CRC, even if the CRC field has not been initialized.
Don't force the MAC address count to MAX_NUM_PORTS or less. Forcing the value to be changed resulting in an in-memory copy that does not match what's in hardware, even though the user did not request that change.
Finally, always update the CRC value in the in-memory copy after any field is changed, so that the CRC is always correct.
Signed-off-by: Timur Tabi timur@freescale.com
board/freescale/common/sys_eeprom.c | 79 ++++++++++++++++++++ +-------------- lib_ppc/board.c | 1 + 2 files changed, 48 insertions(+), 32 deletions(-)
[snip]
diff --git a/lib_ppc/board.c b/lib_ppc/board.c index 6dd4d56..59a56d5 100644 --- a/lib_ppc/board.c +++ b/lib_ppc/board.c @@ -889,6 +889,7 @@ void board_init_r (gd_t *id, ulong dest_addr) #endif
#if defined (CONFIG_ID_EEPROM) || defined (CONFIG_SYS_I2C_MAC_OFFSET)
- puts("EEPROM: ");
mac_read_from_eeprom(); #endif
Wolfgang,
Please ack this bit.
- k
U-Boot mailing list U-Boot@lists.denx.de http://lists.denx.de/mailman/listinfo/u-boot