On 16.10.18 16:46, Michal Simek wrote:
On 16.10.2018 16:25, Alexander Graf wrote:
On 03.10.18 07:45, Michal Simek wrote:
From: Siva Durga Prasad Paladugu siva.durga.paladugu@xilinx.com
This patch gets clock from clock nodes if no clock property found in serial node.
Signed-off-by: Siva Durga Prasad Paladugu sivadur@xilinx.com Signed-off-by: Michal Simek michal.simek@xilinx.com
Is this what Linux does? If so, you probably want to explicitly state that.
yes. Linux does that. On the other hand reading clock property is something what it is out of dt binding spec.
In that case, please at least note that in the patch description or maybe even in a comment in the code, so the next time someone looks at the code they don't get confused :).
Speaking of which, why isn't this handled generically already? I was expecting that find clocks would be a matter of 2 lines of code - or maybe none thanks to magic.
Alex