Hallo Oliver,
On 16.06.20 16:27, Oliver Graute wrote:
Add i.MX8QM qmx8 congatec board support
U-Boot 2020.04-00002-g1ff5446a63 (Jun 16 2020 - 13:47:28 +0200)
CPU: NXP i.MX8QM RevB A53 at 1200 MHz
Model: Congatec QMX8 Qseven series Board: conga-QMX8 Build: SCFW 494c97f3, SECO-FW d7523fe8, ATF 09c5cc9 Boot: SD2 DRAM: 6 GiB Device 'gpio@5d090000': seq 0 is in use by 'gpio@5d080000' Device 'gpio@5d0a0000': seq 1 is in use by 'gpio@5d090000' MMC: FSL_SDHC: 0, FSL_SDHC: 1, FSL_SDHC: 2 Loading Environment from MMC... OK In: serial@5a060000 Out: serial@5a060000 Err: serial@5a060000 switch to partitions #0, OK mmc2 is current device Net: eth0: ethernet@5b040000 Hit any key to stop autoboot: 0
I see some small issues after merging this. There are some warnings that should be fixed before merging, mainly they are missing prototypes that can be easy fixed. This is the log by building the board:
+ 174 | if (!power_domain_lookup_name("conn_sdhc0", &pd)) + | ^~~~~~~~~~~~~~~~~~~~~~~~ + | imx8_power_domain_lookup_name + 178 | init_clk_usdhc(0); + | ^~~~~~~~~~~~~~ + 208 | ret = fsl_esdhc_initialize(bis, &usdhc_cfg[i]); + | ^~~~~~~~~~~~~~~~~~~~ + | fecmxc_initialize + 278 | struct power_domain pd0; + | ^~~ + 442 | board_late_mmc_env_init(); + | ^~~~~~~~~~~~~~~~~~~~~~~ + | board_late_init + 287 | if (ret) + | ^ + 16 | char *autodetect_str = env_get("mmcautodetect"); + | ^~~~~~~ + 41 | env_set_ulong("mmcdev", dev_no); + | ^~~~~~~~~~~~~ + 46 | env_set("mmcroot", mmcblk); + | ^~~~~~~ + 49 | run_command(cmd, 0); + | ^~~~~~~~~~~ + 46 | arch_cpu_init(); + | arch_misc_init + 48 | board_early_init_f(); + | ^~~~~~~~~~~~~~~~~~ + 50 | timer_init(); + | ^~~~~~~~~~ + 75 | board_init_r(NULL, 0); + | ^~~~~~~~~~~~ + | board_init_f
w+board/congatec/cgtqmx8/cgtqmx8.c: In function 'board_mmc_init': w+board/congatec/cgtqmx8/cgtqmx8.c:174:9: warning: implicit declaration of function 'power_domain_lookup_name'; did you mean 'imx8_power_domain_lookup_name'? [-Wimplicit-function-declaration] w+board/congatec/cgtqmx8/cgtqmx8.c:178:4: warning: implicit declaration of function 'init_clk_usdhc' [-Wimplicit-function-declaration] w+board/congatec/cgtqmx8/cgtqmx8.c:208:9: warning: implicit declaration of function 'fsl_esdhc_initialize'; did you mean 'fecmxc_initialize'? [-Wimplicit-function-declaration] w+board/congatec/cgtqmx8/cgtqmx8.c: In function 'board_eth_init': w+board/congatec/cgtqmx8/cgtqmx8.c:278:22: warning: unused variable 'pd0' [-Wunused-variable] w+board/congatec/cgtqmx8/cgtqmx8.c: In function 'board_late_init': w+board/congatec/cgtqmx8/cgtqmx8.c:442:2: warning: implicit declaration of function 'board_late_mmc_env_init'; did you mean 'board_late_init'? [-Wimplicit-function-declaration] w+board/congatec/cgtqmx8/cgtqmx8.c:287:5: warning: 'ret' is used uninitialized in this function [-Wuninitialized] w+board/congatec/common/mmc.c: In function 'check_mmc_autodetect': w+board/congatec/common/mmc.c:16:25: warning: implicit declaration of function 'env_get' [-Wimplicit-function-declaration] w+board/congatec/common/mmc.c:16:25: warning: initialization of 'char *' from 'int' makes pointer from integer without a cast [-Wint-conversion] w+board/congatec/common/mmc.c: In function 'board_late_mmc_env_init': w+board/congatec/common/mmc.c:41:2: warning: implicit declaration of function 'env_set_ulong' [-Wimplicit-function-declaration] w+board/congatec/common/mmc.c:46:2: warning: implicit declaration of function 'env_set' [-Wimplicit-function-declaration] w+board/congatec/common/mmc.c:49:2: warning: implicit declaration of function 'run_command' [-Wimplicit-function-declaration] w+board/congatec/cgtqmx8/spl.c: In function 'spl_board_init': w+board/congatec/cgtqmx8/spl.c:46:2: warning: implicit declaration of function 'arch_cpu_init'; did you mean 'arch_misc_init'? [-Wimplicit-function-declaration] w+board/congatec/cgtqmx8/spl.c:48:2: warning: implicit declaration of function 'board_early_init_f' [-Wimplicit-function-declaration] w+board/congatec/cgtqmx8/spl.c:50:2: warning: implicit declaration of function 'timer_init' [-Wimplicit-function-declaration] w+board/congatec/cgtqmx8/spl.c: In function 'board_init_f': w+board/congatec/cgtqmx8/spl.c:75:2: warning: implicit declaration of function 'board_init_r'; did you mean 'board_init_f'? [-Wimplicit-function-declaration]
Can you fix them and repost it ? Thanks !
Best regards, Stefano