
13 Apr
2016
13 Apr
'16
3:17 p.m.
again, in my travels, i noticed board Makefiles like, say, board/freescale/bsc9131rdb/Makefile:
ifdef MINIMAL
obj-y += spl_minimal.o tlb.o law.o
else
obj-y += bsc9131rdb.o obj-y += ddr.o obj-y += law.o obj-y += tlb.o #obj-y += bsc9131rdb_mux.o
endif
obviously(?), it's redundant to select building tlb.o and law.o in both parts of the conditional, when it could look like:
ifdef MINIMAL
obj-y += spl_minimal.o
else
obj-y += bsc9131rdb.o obj-y += ddr.o #obj-y += bsc9131rdb_mux.o
endif
obj-y += law.o obj-y += tlb.o
is it worth submitting a patch or two that cleans up that sort of thing, perhaps on a vendor-by-vendor basis? i can do that bit by bit if it's worth it.
rday
--
========================================================================
Robert P. J. Day Ottawa, Ontario, CANADA
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================